linux-kernel - Re: [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220603182844.23da48f2@jic23-huawei>
Date:   Fri, 3 Jun 2022 18:28:44 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>
Subject: Re: [PATCH v1 1/1] iio: dac: ad5592r: Get rid of OF specifics

On Tue, 31 May 2022 16:53:20 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> Use dev_fwnode() instead of direct OF node dereference when checking
> for regulator API error code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Applied
> ---
>  drivers/iio/dac/ad5592r-base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
> index 4434c1b2a322..7a9b5fc1e579 100644
> --- a/drivers/iio/dac/ad5592r-base.c
> +++ b/drivers/iio/dac/ad5592r-base.c
> @@ -603,7 +603,7 @@ int ad5592r_probe(struct device *dev, const char *name,
>  
>  	st->reg = devm_regulator_get_optional(dev, "vref");
>  	if (IS_ERR(st->reg)) {
> -		if ((PTR_ERR(st->reg) != -ENODEV) && dev->of_node)
> +		if ((PTR_ERR(st->reg) != -ENODEV) && dev_fwnode(dev))
>  			return PTR_ERR(st->reg);
>  
>  		st->reg = NULL;