linux-kernel - Re: [PATCH v2 1/6] serial: 8250: Store to lsr_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Jun 2022 19:01:15 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "Matwey V. Kornilov" <matwey@....msu.ru>,
        LKML <linux-kernel@...r.kernel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2 1/6] serial: 8250: Store to lsr_save_flags after lsr read

On Mon, Jun 6, 2022 at 6:54 PM Ilpo Järvinen
<ilpo.jarvinen@...ux.intel.com> wrote:
> On Mon, 6 Jun 2022, Andy Shevchenko wrote:
> > On Mon, Jun 6, 2022 at 3:55 PM Ilpo Järvinen
> > <ilpo.jarvinen@...ux.intel.com> wrote:

...

> > But more importantly I do not see the reason for the Acked-by tag when
> > SoB of the same person is present.
>
> I just repeated what Uwe gave me. Maybe he didn't notice he was already
> there as SoB.
>
> This situation is anyway a bit more complex than usual. The line I took
> was part of Uwe's much larger patch initially (which was fully reverted)
> so his SoB was carried over to preserve the authorship. As I made a
> non-trivial modification to his original patch by removing almost all of
> it, I added my SoB too. Given this situation, I kind of thought he Acked
> (approved) the post-modification version of it.

I believe you haven't preserved the authorship that way (since From
line is different), but since you have done non-trivial changes and
Uwe is okay with them, the straightforward tag chain would be (with
your authorship implied):
Co-developed-by: Uwe
SoB: Uwe
SoB: yours

-- 
With Best Regards,
Andy Shevchenko