linux-kernel - Re: [PATCH v5 4/7] can: Kconfig: add CONFIG_CAN_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXkq7+yvD=ju-LY14yOPkiiHwL6H+9G-4KgX=GJjX=h9g@mail.gmail.com>
Date:   Tue, 7 Jun 2022 10:43:08 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>, linux-can@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Max Staudt <max@...as.org>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 4/7] can: Kconfig: add CONFIG_CAN_RX_OFFLOAD

Hi Vincent,

On Sun, Jun 5, 2022 at 12:25 AM Vincent Mailhol
<mailhol.vincent@...adoo.fr> wrote:
> Only a few drivers rely on the CAN rx offload framework (as of the
> writing of this patch, only four: flexcan, m_can, mcp251xfd and
> ti_hecc). Give the option to the user to deselect this features during
> compilation.

Thanks for your patch!

> The drivers relying on CAN rx offload are in different sub
> folders. All of these drivers get tagged with "select CAN_RX_OFFLOAD"
> so that the option is automatically enabled whenever one of those
> driver is chosen.

Great! But...

>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>

> --- a/drivers/net/can/Kconfig
> +++ b/drivers/net/can/Kconfig
> @@ -102,6 +102,20 @@ config CAN_CALC_BITTIMING
>
>           If unsure, say Y.
>
> +config CAN_RX_OFFLOAD
> +       bool "CAN RX offload"
> +       default y

... then why does this default to "y"?

> +       help
> +         Framework to offload the controller's RX FIFO during one
> +         interrupt. The CAN frames of the FIFO are read and put into a skb
> +         queue during that interrupt and transmitted afterwards in a NAPI
> +         context.
> +
> +         The additional features selected by this option will be added to the
> +         can-dev module.
> +
> +         If unsure, say Y.

... and do you suggest to enable this?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds