lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Jun 2022 17:20:07 +0800 From: CK Hu <ck.hu@...iatek.com> To: Moudy Ho <moudy.ho@...iatek.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Hans Verkuil <hverkuil-cisco@...all.nl> CC: Chun-Kuang Hu <chunkuang.hu@...nel.org>, Rob Landley <rob@...dley.net>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, Alexandre Courbot <acourbot@...omium.org>, <tfiga@...omium.org>, <drinkcat@...omium.org>, <pihsun@...omium.org>, <hsinyi@...gle.com>, Benjamin Gaignard <benjamin.gaignard@...labora.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, daoyuan huang <daoyuan.huang@...iatek.com>, Ping-Hsun Wu <ping-hsun.wu@...iatek.com>, <allen-kh.cheng@...iatek.com>, <xiandong.wang@...iatek.com>, <randy.wu@...iatek.com>, <jason-jh.lin@...iatek.com>, <roy-cw.yeh@...iatek.com>, <river.cheng@...iatek.com>, <Project_Global_Chrome_Upstream_Group@...iatek.com>, <cellopoint.kai@...il.com> Subject: Re: [PATCH v19 6/6] soc: mediatek: mutex: add functions that operate registers by CMDQ Hi, Moudy: On Tue, 2022-05-31 at 13:52 +0800, Moudy Ho wrote: > Due to HW limitations, MDP3 is necessary to enable MUTEX in each > frame > for SOF triggering and cooperate with CMDQ control to reduce the > amount > of interrupts generated(also, reduce frame latency). > > In response to the above situation, a new interface > "mtk_mutex_enable_by_cmdq" has been added to achieve the purpose. Reviewed-by: CK Hu <ck.hu@...iatek.com> > > Signed-off-by: Moudy Ho <moudy.ho@...iatek.com> > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@...labora.com> > Reviewed-by: Rex-BC Chen <rex-bc.chen@...iatek.com> > --- > drivers/soc/mediatek/mtk-mutex.c | 45 > +++++++++++++++++++++++++- > include/linux/soc/mediatek/mtk-mutex.h | 2 ++ > 2 files changed, 46 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > b/drivers/soc/mediatek/mtk-mutex.c > index 23009445adb4..b93dd391fc86 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -7,10 +7,12 @@ > #include <linux/iopoll.h> > #include <linux/module.h> > #include <linux/of_device.h> > +#include <linux/of_address.h> > #include <linux/platform_device.h> > #include <linux/regmap.h> > #include <linux/soc/mediatek/mtk-mmsys.h> > #include <linux/soc/mediatek/mtk-mutex.h> > +#include <linux/soc/mediatek/mtk-cmdq.h> > > #define MT2701_MUTEX0_MOD0 0x2c > #define MT2701_MUTEX0_SOF0 0x30 > @@ -204,6 +206,8 @@ struct mtk_mutex_ctx { > void __iomem *regs; > struct mtk_mutex mutex[10]; > const struct mtk_mutex_data *data; > + phys_addr_t addr; > + struct cmdq_client_reg cmdq_reg; > }; > > static const unsigned int mt2701_mutex_mod[DDP_COMPONENT_ID_MAX] = { > @@ -594,6 +598,30 @@ void mtk_mutex_enable(struct mtk_mutex *mutex) > } > EXPORT_SYMBOL_GPL(mtk_mutex_enable); > > +int mtk_mutex_enable_by_cmdq(struct mtk_mutex *mutex, void *pkt) > +{ > + struct mtk_mutex_ctx *mtx = container_of(mutex, struct > mtk_mutex_ctx, > + mutex[mutex->id]); > +#if IS_REACHABLE(CONFIG_MTK_CMDQ) > + struct cmdq_pkt *cmdq_pkt = (struct cmdq_pkt *)pkt; > + > + WARN_ON(&mtx->mutex[mutex->id] != mutex); > + > + if (!mtx->cmdq_reg.size) { > + dev_err(mtx->dev, "mediatek,gce-client-reg hasn't been > set"); > + return -EINVAL; > + } > + > + cmdq_pkt_write(cmdq_pkt, mtx->cmdq_reg.subsys, > + mtx->addr + DISP_REG_MUTEX_EN(mutex->id), 1); > + return 0; > +#else > + dev_err(mtx->dev, "Not support for enable MUTEX by CMDQ"); > + return -ENODEV; > +#endif > +} > +EXPORT_SYMBOL_GPL(mtk_mutex_enable_by_cmdq); > + > void mtk_mutex_disable(struct mtk_mutex *mutex) > { > struct mtk_mutex_ctx *mtx = container_of(mutex, struct > mtk_mutex_ctx, > @@ -690,8 +718,11 @@ static int mtk_mutex_probe(struct > platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct mtk_mutex_ctx *mtx; > - struct resource *regs; > + struct resource *regs, addr; > int i; > +#if IS_REACHABLE(CONFIG_MTK_CMDQ) > + int ret; > +#endif > > mtx = devm_kzalloc(dev, sizeof(*mtx), GFP_KERNEL); > if (!mtx) > @@ -711,6 +742,18 @@ static int mtk_mutex_probe(struct > platform_device *pdev) > } > } > > + if (of_address_to_resource(dev->of_node, 0, &addr) < 0) { > + dev_err(dev, "Failed to get addr\n"); > + return -EINVAL; > + } > + mtx->addr = addr.start; > + > +#if IS_REACHABLE(CONFIG_MTK_CMDQ) > + ret = cmdq_dev_get_client_reg(dev, &mtx->cmdq_reg, 0); > + if (ret) > + dev_dbg(dev, "No mediatek,gce-client-reg!\n"); > +#endif > + > regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > mtx->regs = devm_ioremap_resource(dev, regs); > if (IS_ERR(mtx->regs)) { > diff --git a/include/linux/soc/mediatek/mtk-mutex.h > b/include/linux/soc/mediatek/mtk-mutex.h > index 829231523e3f..385ec8795c1d 100644 > --- a/include/linux/soc/mediatek/mtk-mutex.h > +++ b/include/linux/soc/mediatek/mtk-mutex.h > @@ -35,6 +35,8 @@ int mtk_mutex_prepare(struct mtk_mutex *mutex); > void mtk_mutex_add_comp(struct mtk_mutex *mutex, > enum mtk_ddp_comp_id id); > void mtk_mutex_enable(struct mtk_mutex *mutex); > +int mtk_mutex_enable_by_cmdq(struct mtk_mutex *mutex, > + void *pkt); > void mtk_mutex_disable(struct mtk_mutex *mutex); > void mtk_mutex_remove_comp(struct mtk_mutex *mutex, > enum mtk_ddp_comp_id id);
Powered by blists - more mailing lists