lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Tue, 7 Jun 2022 10:28:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Tony Luck <tony.luck@...el.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: [intel-tdx:guest-attest 5/8] arch/x86/coco/tdx/attest.c:249:6:
 warning: no previous prototype for 'terminate_quote_request'

tree:   https://github.com/intel/tdx.git guest-attest
head:   cf3131ea46807abb401d633e20dd28ef77c0dba8
commit: 976cd8bda2b0e7ea9f415585aaa1b2ea5a2d0075 [5/8] x86/tdx: Add Quote generation support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220607/202206071034.SxfYlULc-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel/tdx/commit/976cd8bda2b0e7ea9f415585aaa1b2ea5a2d0075
        git remote add intel-tdx https://github.com/intel/tdx.git
        git fetch --no-tags intel-tdx guest-attest
        git checkout 976cd8bda2b0e7ea9f415585aaa1b2ea5a2d0075
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/coco/tdx/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/x86/coco/tdx/attest.c:249:6: warning: no previous prototype for 'terminate_quote_request' [-Wmissing-prototypes]
     249 | void terminate_quote_request(struct quote_entry *entry)
         |      ^~~~~~~~~~~~~~~~~~~~~~~


vim +/terminate_quote_request +249 arch/x86/coco/tdx/attest.c

   247	
   248	/* Handles early termination of GetQuote requests */
 > 249	void terminate_quote_request(struct quote_entry *entry)
   250	{
   251		struct tdx_quote_hdr *quote_hdr;
   252	
   253		/*
   254		 * For early termination, if the request is not yet
   255		 * processed by VMM (GET_QUOTE_IN_FLIGHT), the VMM
   256		 * still owns the shared buffer, so mark the request
   257		 * invalid to let quote_callback_handler() handle the
   258		 * memory cleanup function. If the request is already
   259		 * processed, then do the cleanup and return.
   260		 */
   261	
   262		mutex_lock(&quote_lock);
   263		quote_hdr = (struct tdx_quote_hdr *)entry->buf.vmaddr;
   264		if (quote_hdr->status == GET_QUOTE_IN_FLIGHT) {
   265			entry->valid = false;
   266			mutex_unlock(&quote_lock);
   267			return;
   268		}
   269		_del_quote_entry(entry);
   270		mutex_unlock(&quote_lock);
   271	}
   272	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ