linux-kernel - Re: [PATCH v3 0/4] Add support for XP-PEN Deco L

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2206081150060.10851@cbobk.fhfr.pm>
Date:   Wed, 8 Jun 2022 11:51:03 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     José Expósito <jose.exposito89@...il.com>
cc:     benjamin.tissoires@...hat.com, spbnick@...il.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        stefanberzl@...il.com, dlatypov@...gle.com,
        kunit-dev@...glegroups.com
Subject: Re: [PATCH v3 0/4] Add support for XP-PEN Deco L

On Mon, 6 Jun 2022, José Expósito wrote:

> > This patchset adds support for the UGEE XP-PEN Deco L tablet.
> > This device belongs to a family of tablets that must receive a chunk of
> > magic data in order to be enabled (named UGEE v2 internally).
> >
> > [...]
> >
> > ---
> > 
> > v1 - Initial version
> > https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/
> > 
> > v2 - Fix some errors reported by the kernel test robot:
> > 
> >  - Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c
> >  - Remove unused variable in uclogic_params_ugee_v2_init
> >  - Add sparse __force anotation in the result of cpu_to_le16
> >  - Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests
> > 
> > https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/T/
> > 
> > v3 - This version:
> > 
> >  - Improve Kconfig message
> >  - Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an
> >    unrelated patch:
> >    https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/
> 
> As mentioned in the v3 changelog, I'm working on a DRM patch including
> a few KUnit tests [1].
> 
> Some interesting highlights from the comments there:
> 
> - It looks like the maintainers prefer to include a single symbol [2]
> to enable all tests in the subsystem.
> 
> Jiří, Benjamin, how would you like to handle it? Would you prefer to
> have a symbol for each test (HID_UCLOGIC_KUNIT_TEST)? Or a symbol for
> all tests (HID_KUNIT_TEST)?

I don't really see any benefit in breaking it down to per-driver tests, so 
yes, please hide it all under one unified HID_KUNIT_TEST as far as I am 
concerned.

Thanks,

-- 
Jiri Kosina
SUSE Labs