linux-kernel - Re: [PATCH v2] usb: host: ohci-at91: add support to enter suspend using SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqCqMsr7FxT/KtZk@rowland.harvard.edu>
Date:   Wed, 8 Jun 2022 09:54:58 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Clément Léger <clement.leger@...tlin.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2] usb: host: ohci-at91: add support to enter suspend
 using SMC

On Tue, Jun 07, 2022 at 03:34:54PM +0200, Clément Léger wrote:
> When Linux is running under OP-TEE, the SFR is set as secured and thus
> the AT91_OHCIICR_USB_SUSPEND register isn't accessible. Add a SMC to
> do the appropriate call to suspend the controller.
> The SMC id is fetched from the device-tree property
> "microchip,suspend-smc-id". if present, then the syscon regmap is not
> used to enter suspend and a SMC is issued.
> 
> Signed-off-by: Clément Léger <clement.leger@...tlin.com>
> ---
> 
> Notes:
>     Changes in V2:
>      - Change check order in ohci_at91_port_suspend()
>      - Renamed smc_id to suspend_smc_id for clarity

Acked-by: Alan Stern <stern@...land.harvard.edu>