linux-kernel - RE: [PATCH v1] regmap: add generic indirect regmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB548315C03B09D841B6392E63E3A49@BN9PR11MB5483.namprd11.prod.outlook.com>
Date:   Wed, 8 Jun 2022 23:54:26 +0000
From:   "Zhang, Tianfei" <tianfei.zhang@...el.com>
To:     Mark Brown <broonie@...nel.org>,
        "matthew.gerlach@...ux.intel.com" <matthew.gerlach@...ux.intel.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Wu, Hao" <hao.wu@...el.com>, "trix@...hat.com" <trix@...hat.com>,
        "Xu, Yilun" <yilun.xu@...el.com>,
        "Weight, Russell H" <russell.h.weight@...el.com>
Subject: RE: [PATCH v1] regmap: add generic indirect regmap support



> -----Original Message-----
> From: Mark Brown <broonie@...nel.org>
> Sent: Wednesday, June 8, 2022 6:43 PM
> To: matthew.gerlach@...ux.intel.com
> Cc: Zhang, Tianfei <tianfei.zhang@...el.com>; gregkh@...uxfoundation.org;
> rafael@...nel.org; linux-kernel@...r.kernel.org; Wu, Hao
> <hao.wu@...el.com>; trix@...hat.com; Xu, Yilun <yilun.xu@...el.com>;
> Weight, Russell H <russell.h.weight@...el.com>
> Subject: Re: [PATCH v1] regmap: add generic indirect regmap support
> 
> On Tue, Jun 07, 2022 at 05:27:38PM -0700, matthew.gerlach@...ux.intel.com
> wrote:
> > On Tue, 7 Jun 2022, Mark Brown wrote:
> > > On Mon, Jun 06, 2022 at 09:37:55PM -0400, Tianfei Zhang wrote:
> > > > From: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
> 
> > > > This patch adds support for regmap APIs that are intended to be
> > > > used by the drivers of some devices which support generic indirect
> > > > register access, for example PMCI (Platform Management Control
> > > > Interface) device, HSSI (High Speed Serial Interface) device in FPGA.
> 
> > > What is "generic indirect register access"?  I'm not clear what this
> > > is intended to support...
> 
> > "indirect register access" is a RTL design pattern we use in FPGAs
> > frequently.  The design pattern involves a small number of registers
> > plus a little handshake code to access various register spaces inside
> > the FPGA fabric.  The design pattern is "generic" in the sense that
> > the same small number of registers and handshake can be used with many
> > different IP components in the FPGA.  Historically, the bit
> > definitions and handshaking was slightly different for each IP
> > component.  This is an attempt at a consistent usage across IP components.
> 
> > Would a different name help?
> 
> This wouldn't address the major problem which is...
> 
> > > > +	writel(0, ctx->base + INDIRECT_CMD_OFF);
> > > > +	ret = readl_poll_timeout((ctx->base + INDIRECT_CMD_OFF), cmd,
> > > > +				 (!cmd), INDIRECT_INT_US,
> INDIRECT_TIMEOUT_US);
> > > > +	if (ret)
> > > > +		dev_err(ctx->dev, "%s timed out on clearing cmd 0x%xn",
> > > > +__func__, cmd);
> 
> > > ...and this doesn't look particularly generic, it looks like it's
> > > for some particular controller/bridge?
> 
> ...that this appears to be entirely specific to some particular device, it's got
> things like hard coded register addresses and timeouts which mean it can't be
> reused.

Yet, this is a register access hardware controller/bridge widely used in FPGA IP blocks, like PMCI, HSSI.
How about we change the patch title like this:

regmap: add indirect register controller support