linux-kernel - Re: [PATCH] auxdisplay: ht16k33: Use backlight helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220607230231.07e36338@heffalump.sk2.org>
Date:   Tue, 7 Jun 2022 23:02:31 +0200
From:   Stephen Kitt <steve@....org>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Robin van der Gracht <robin@...tonic.nl>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] auxdisplay: ht16k33: Use backlight helper

Hi Miguel,

On Tue, 7 Jun 2022 21:08:34 +0200, Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
> On Tue, Jun 7, 2022 at 8:04 PM Stephen Kitt <steve@....org> wrote:
> > backlight_properties.fb_blank is deprecated. The states it represents
> > are handled by other properties; but instead of accessing those
> > properties directly, drivers should use the helpers provided by
> > backlight.h.
> >
> > Instead of retrieving the backlight brightness in struct
> > backlight_properties manually, and then checking whether the backlight
> > should be on at all, use backlight_get_brightness() which does all
> > this and insulates this from future changes.  
> 
> Thanks for the patch! Looks good to me.
> 
> There is a functional change in that `BL_CORE_SUSPENDED` is taken into
> account with this change, but I assume that is expected. In that case,
> it could be good to mention it in the commit message.

That’s a good point, and it is indeed expected; I’ll add it to the commit
message.

Regards,

Stephen

Content of type "application/pgp-signature" skipped