linux-kernel - Re: [PATCH] virtio: Directly use ida_alloc_range()/ida

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22584780-a2eb-0a83-daaa-f259aa2adc42@wanadoo.fr>
Date:   Thu, 9 Jun 2022 06:59:23 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     tomorrow Wang (王德明) 
        <wangdeming@...pur.com>, "mst@...hat.com" <mst@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio: Directly use ida_alloc_range()/ida_free()

Le 09/06/2022 à 02:42, tomorrow Wang (王德明) a écrit :
>>
>> An explanation in the commit log of why the -1 is needed would also help
>> reviewer/maintainer, IMHO.
>>
>> It IS correct, but it is not that obvious without looking at
>> ida_simple_get() and ida_alloc_range().
>>
> 
> can I mention one patch about repair ida_free  for this.
> 
> 

If you manage to find another patch and provide a lore.kernel.org link 
to it, I think it should be okay.

However, after a *quick* look in some mailing list, I've not found yet a 
description for that.

CJ