linux-kernel - Re: [PATCH] virtio: Directly use ida_alloc_range()/ida

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <aff7bba2680b49fab6a14694e33fd41d@inspur.com>
Date:   Thu, 9 Jun 2022 00:42:11 +0000
From:   tomorrow Wang (王德明) 
        <wangdeming@...pur.com>
To:     "christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
        "mst@...hat.com" <mst@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio: Directly use ida_alloc_range()/ida_free()

Hi,
> Hi,
> 
> Le 08/06/2022 à 08:08, Deming Wang a écrit :
> > Use ida_alloc_range()/ida_free() instead of deprecated
> > ida_simple_get()/ida_simple_remove() .
> >
> > Signed-off-by: Deming Wang <wangdeming@...pur.com>
> > ---
> >   drivers/vhost/vdpa.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index
> > 935a1d0ddb97..384049cfca8d 100644
> > --- a/drivers/vhost/vdpa.c
> > +++ b/drivers/vhost/vdpa.c
> > @@ -1293,7 +1293,7 @@ static void vhost_vdpa_release_dev(struct device
> *device)
> >   	struct vhost_vdpa *v =
> >   	       container_of(device, struct vhost_vdpa, dev);
> >
> > -	ida_simple_remove(&vhost_vdpa_ida, v->minor);
> > +	ida_free(&vhost_vdpa_ida, v->minor);
> >   	kfree(v->vqs);
> >   	kfree(v);
> >   }
> > @@ -1316,8 +1316,7 @@ static int vhost_vdpa_probe(struct vdpa_device
> *vdpa)
> >   	if (!v)
> >   		return -ENOMEM;
> >
> > -	minor = ida_simple_get(&vhost_vdpa_ida, 0,
> > -			       VHOST_VDPA_DEV_MAX, GFP_KERNEL);
> > +	minor = ida_alloc_range(&vhost_vdpa_ida, 0, VHOST_VDPA_DEV_MAX -
> 1,
> > +GFP_KERNEL);
> 
> ida_alloc_max() would be better here. It is less verbose.
> 
> An explanation in the commit log of why the -1 is needed would also help
> reviewer/maintainer, IMHO.
> 
> It IS correct, but it is not that obvious without looking at
> ida_simple_get() and ida_alloc_range().
> 
> CJ
> 
> 
> >   	if (minor < 0) {
> >   		kfree(v);
> >   		return minor;


can I mention one patch about repair ida_free  for this.





Download attachment "smime.p7s" of type "application/pkcs7-signature" (3780 bytes)