[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220609192827.GA2167717@roeck-us.net>
Date: Thu, 9 Jun 2022 12:28:27 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Aleksa Savic <savicaleksa83@...il.com>
Cc: linux-hwmon@...r.kernel.org, Jack Doan <me@...kdoan.com>,
Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Move device-specific data
into struct aqc_data
On Thu, Jun 09, 2022 at 08:59:35PM +0200, Aleksa Savic wrote:
> As preparation for adding support for more devices in upcoming patches,
> move device-specific data, such as number of fans, temperature sensors,
> register offsets etc. to struct aqc_data. This is made possible by
> the fact that the supported Aquacomputer devices share the same layouts
> of sensor substructures. This allows aqc_raw_event() and others to stay
> general and not be cluttered with similar loops for each device.
>
This is doing way more than that; it removes a lot of defines and
replaces them with constants, making it all but impossible to reliably
review the patch. That alone makes it unacceptable. On top of that,
I am not going to participate in a "thou shall use defines" vs.
"thou shall use raw constants" editing war. The driver uses defines
for constants. Keep using them.
Guenter
Powered by blists - more mailing lists