linux-kernel - Re: [PATCH] hwmon: (aquacomputer_d5next) Move device-specific data into struct aqc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqJL0lc0/u55woBQ@DESKTOP-A98GP49>
Date:   Thu, 9 Jun 2022 21:36:50 +0200
From:   Aleksa Savic <savicaleksa83@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-hwmon@...r.kernel.org, Jack Doan <me@...kdoan.com>,
        Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Move device-specific data
 into struct aqc_data

On Thu, Jun 09, 2022 at 12:28:27PM -0700, Guenter Roeck wrote:
> On Thu, Jun 09, 2022 at 08:59:35PM +0200, Aleksa Savic wrote:
> > As preparation for adding support for more devices in upcoming patches,
> > move device-specific data, such as number of fans, temperature sensors,
> > register offsets etc. to struct aqc_data. This is made possible by
> > the fact that the supported Aquacomputer devices share the same layouts
> > of sensor substructures. This allows aqc_raw_event() and others to stay
> > general and not be cluttered with similar loops for each device.
> > 
> 
> This is doing way more than that; it removes a lot of defines and
> replaces them with constants, making it all but impossible to reliably
> review the patch. That alone makes it unacceptable. On top of that,
> I am not going to participate in a "thou shall use defines" vs.
> "thou shall use raw constants" editing war. The driver uses defines
> for constants. Keep using them.
> 
> Guenter

Understood, thanks :). Will rework it in v2.

Aleksa