linux-kernel - Re: [PATCH v2 1/5] dt-bindings: input: Increase maximum keycode value to 0x2ff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 20:29:38 -0500
From:   Jeff LaBundy <jeff@...undy.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Heinrich Schuchardt <xypron.glpk@....de>,
        Hans de Goede <hdegoede@...hat.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Artur Rojek <contact@...ur-rojek.eu>,
        Maxime Ripard <mripard@...nel.org>,
        linux-input@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: input: Increase maximum keycode
 value to 0x2ff

Hi Rob,

On Wed, Jun 08, 2022 at 03:12:03PM -0600, Rob Herring wrote:
> The maximum keycode value for Linux is 0x2ff, not 0xff. There's already
> users and examples with values greater than 0xff, but the schema is not
> yet applied in those cases.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>

As the creator of a few said examples:

Reviewed-by: Jeff LaBundy <jeff@...undy.com>

> ---
>  Documentation/devicetree/bindings/input/input.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml
> index d41d8743aad4..43d2f299c332 100644
> --- a/Documentation/devicetree/bindings/input/input.yaml
> +++ b/Documentation/devicetree/bindings/input/input.yaml
> @@ -21,7 +21,7 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32-array
>      items:
>        minimum: 0
> -      maximum: 0xff
> +      maximum: 0x2ff
>  
>    poll-interval:
>      description: Poll interval time in milliseconds.
> -- 
> 2.34.1
> 

Thank you for driving this series.

Kind regards,
Jeff LaBundy