linux-kernel - Re: [PATCH 05/14] ARM: dts: qcom: msm8974: add dedicated IMEM compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5573836.DvuYhMxLoT@g550jk>
Date:   Fri, 10 Jun 2022 22:54:15 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Brian Masney <masneyb@...tation.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH 05/14] ARM: dts: qcom: msm8974: add dedicated IMEM compatible

Hi Krzysztof,

On Dienstag, 7. Juni 2022 19:18:39 CEST Krzysztof Kozlowski wrote:
> syscon compatible must be preceded with a specific compatible, to
> accurately describe the device.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Luca Weiss <luca@...tu.xyz>

> ---
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
> b/arch/arm/boot/dts/qcom-msm8974.dtsi index 09b181bb5365..5e6b2ae72e62
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1651,7 +1651,7 @@ smd-edge {
>  		};
> 
>  		imem: sram@...05000 {
> -			compatible = "syscon", "simple-mfd";
> +			compatible = "qcom,msm8974-imem", "syscon", 
"simple-mfd";
>  			reg = <0xfe805000 0x1000>;
> 
>  			reboot-mode {