[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2632793.mvXUDI8C0e@g550jk>
Date: Fri, 10 Jun 2022 22:53:55 +0200
From: Luca Weiss <luca@...tu.xyz>
To: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Brian Masney <masneyb@...tation.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH 03/14] ARM: dts: qcom: use generic sram as name for imem and ocmem nodes
Hi Krzysztof,
On Dienstag, 7. Juni 2022 19:18:37 CEST Krzysztof Kozlowski wrote:
> According to Devicetree specification, the device nodes should be
> generic, reflecting the function of the device. The typical name for
> memory regions is "sram".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Reviewed-by: Luca Weiss <luca@...tu.xyz>
Regards
Luca
> ---
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 2 +-
> arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts index
> ca9f73528196..de01e34409f2 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -341,7 +341,7 @@ mmc@...00000 {
> };
> };
>
> - imem@...3f000 {
> + sram@...3f000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x2a03f000 0x1000>;
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi
> b/arch/arm/boot/dts/qcom-msm8974.dtsi index 814ad0b46232..09b181bb5365
> 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1603,7 +1603,7 @@ opp-27000000 {
> };
> };
>
> - ocmem@...00000 {
> + sram@...00000 {
> compatible = "qcom,msm8974-ocmem";
> reg = <0xfdd00000 0x2000>,
> <0xfec00000 0x180000>;
> @@ -1650,7 +1650,7 @@ smd-edge {
> };
> };
>
> - imem: imem@...05000 {
> + imem: sram@...05000 {
> compatible = "syscon", "simple-mfd";
> reg = <0xfe805000 0x1000>;
>
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi
> b/arch/arm/boot/dts/qcom-sdx55.dtsi index 1c2b208a5670..710c7f772d42 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -561,7 +561,7 @@ tlmm: pinctrl@...0000 {
> #interrupt-cells = <2>;
> };
>
> - imem@...8f000 {
> + sram@...8f000 {
> compatible = "simple-mfd";
> reg = <0x1468f000 0x1000>;
Powered by blists - more mailing lists