linux-kernel - RE: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Jun 2022 06:51:41 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "francesco.dolcini@...adex.com" <francesco.dolcini@...adex.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the
 proper places

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@...nel.org>
> Sent: 2022年6月10日 0:26
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: l.stach@...gutronix.de; bhelgaas@...gle.com; robh+dt@...nel.org;
> broonie@...nel.org; lorenzo.pieralisi@....com; jingoohan1@...il.com;
> festevam@...il.com; francesco.dolcini@...adex.com;
> linux-pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; kernel@...gutronix.de; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the
> proper places
> 
> On Thu, Jun 09, 2022 at 06:20:16AM +0000, Hongxing Zhu wrote:
> > > -----Original Message-----
> > > From: Bjorn Helgaas <helgaas@...nel.org>
> > > Sent: 2022年6月9日 2:58
> > > To: Hongxing Zhu <hongxing.zhu@....com>
> > > Cc: l.stach@...gutronix.de; bhelgaas@...gle.com; robh+dt@...nel.org;
> > > broonie@...nel.org; lorenzo.pieralisi@....com; jingoohan1@...il.com;
> > > festevam@...il.com; francesco.dolcini@...adex.com;
> > > linux-pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> > > linux-kernel@...r.kernel.org; kernel@...gutronix.de; dl-linux-imx
> > > <linux-imx@....com>
> > > Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks
> > > to the proper places
> > >
> > > On Fri, May 06, 2022 at 09:47:08AM +0800, Richard Zhu wrote:
> > > > To make it more reasonable, move the phy_power_on/phy_init
> > > > callbacks to the proper places.
> > > > - move the phy_power_on() out of imx6_pcie_clk_enable().
> > > > - move the phy_init() out of imx6_pcie_deassert_core_reset().
> > >
> > > I'm not sure what "make it more reasonable" is telling me.  In
> > > subject line and commit log, please say something more specific than
> > > "the proper places."
> > >
> > > It's probably more important to say where they are moving *to* than
> > > where they're moving *out of*.
> 
> > Thanks for your comments.
> > In another review loop listed below, Lucas used said that it's not
> > good to hide PHY init in imx6_pcie_assert_core_reset() So, I make a
> > try to move the phy_init() out of imx6_pcie_assert_core_reset().
> > And move phy_power_on() out of imx6_pcie_clk_enable() accordingly.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.kernel.org%2Fproject%2Flinux-pci%2Fpatch%2F1646289275-17813-1-g
> i
> >
> t-send-email-hongxing.zhu%40nxp.com%2F&amp;data=05%7C01%7Chongxing
> .zhu
> > %40nxp.com%7C0094cb503bd64d9d8c0008da4a34bbc8%7C686ea1d3bc2b
> 4c6fa92cd9
> >
> 9c5c301635%7C0%7C0%7C637903887598125451%7CUnknown%7CTWFpbG
> Zsb3d8eyJWIj
> >
> oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00%7C
> > %7C%7C&amp;sdata=ntbjAv6s3M0mUI8uCAUX23HiPNBlgvWKlAaw7lAh%2F
> pE%3D&amp;
> > reserved=0 Okay, I would specific that they are moving *to* later.
> >
> > > > In order to save power consumption, turn off the clocks and
> > > > regulators when the imx6_pcie_host_init() return error.
> > >
> > > Is the power savings the *reason* for this change?  I can't tell
> > > from the commit log.
> >
> > The error handling of the imx6_pcie_host_init() is not mentioned in
> > the subject.  Should I split these changes into two patches?
> 
> If they can be split, they probably should be split.
Got that, thanks a lot.

Best Regards
Richard Zhu