linux-kernel - Re: [PATCH v2] crypto: octeontx2: fix potential null pointer access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqMMBUzHTCOv9UzM@gondor.apana.org.au>
Date:   Fri, 10 Jun 2022 17:16:53 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Shijith Thotton <sthotton@...vell.com>
Cc:     Arnaud Ebalard <arno@...isbad.org>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        linux-crypto@...r.kernel.org, jerinj@...vell.com,
        sgoutham@...vell.com, Srujana Challa <schalla@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Kees Cook <keescook@...omium.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] crypto: octeontx2: fix potential null pointer access

On Wed, Jun 01, 2022 at 01:38:59PM +0530, Shijith Thotton wrote:
> Added missing checks to avoid null pointer dereference.
> 
> The patch fixes below issue reported by klocwork tool:
> . Pointer 'strsep( &val, ":" )' returned from call to function 'strsep'
>   at line 1608 may be NULL and will be dereferenced at line 1608. Also
>   there are 2 similar errors on lines 1620, 1632 in otx2_cptpf_ucode.c.
> 
> Signed-off-by: Shijith Thotton <sthotton@...vell.com>
> ---
> v2:
> * Removed unwanted check for pcim_iomap_table.
> 
>  .../crypto/marvell/octeontx2/otx2_cptpf_ucode.c   | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt