linux-kernel - RE: [PATCH -next] phy: samsung-ufs: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000601d87caa$cede0150$6c9a03f0$@samsung.com>
Date:   Fri, 10 Jun 2022 14:46:44 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Chanho Park'" <chanho61.park@...sung.com>,
        <linux-kernel@...r.kernel.org>, <linux-phy@...ts.infradead.org>
Cc:     <krzysztof.kozlowski+dt@...aro.org>, <vkoul@...nel.org>,
        <pankaj.dubey@...sung.com>
Subject: RE: [PATCH -next] phy: samsung-ufs: fix NULL pointer dereference



>-----Original Message-----
>From: Chanho Park [mailto:chanho61.park@...sung.com]
>Sent: Friday, June 10, 2022 1:45 PM
>To: 'Alim Akhtar' <alim.akhtar@...sung.com>; linux-kernel@...r.kernel.org;
>linux-phy@...ts.infradead.org
>Cc: krzysztof.kozlowski+dt@...aro.org; vkoul@...nel.org;
>pankaj.dubey@...sung.com
>Subject: RE: [PATCH -next] phy: samsung-ufs: fix NULL pointer dereference
>
>> Subject: [PATCH -next] phy: samsung-ufs: fix NULL pointer dereference
>>
>> commit f86c1d0a58b1f63a ("phy: samsung: ufs: remove drvdata from
>> struct
>> samsung_ufs_phy")
>>
>> removes _drvdata_ initialization which resulting in NULL pointer
>> dereferencing in samsung_ufs_phy_wait_for_lock_acq(). Fix this by
>> initializing drvdata.
>>
>> The said commit also duplicate "has_symbol_clk" both in drvdata struct
>> and in samsung_ufs_phy struct, let's go back and use only one
>"has_symbol_clk".
>>
>> Fixes: f86c1d0a58b1 phy: samsung: ufs: remove drvdata from struct
>> samsung_ufs_phy
>
>This might be conflicted when you apply your patch.
>https://lore.kernel.org/linux-phy/20220610072924.12362-3-
>alim.akhtar@...sung.com/T/#u
>
>When I created my patch, it was not existing so my previous patch make
>sense.
>If you get back drvdata for your patch, please drop this "fixes tag + patch" and
>put this in your patchset.
>
Thanks Chanho
Because of the merged conflict this got messed up. Will correct it.

>Best Regards,
>Chanho Park