linux-kernel - Re: [PATCH] genirq/PM: Unexport {suspend,resume}_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jBVyxegaETv5D25N+LNZWRUsJeVcx-p8cGXYod8=smWQ@mail.gmail.com>
Date:   Fri, 10 Jun 2022 15:33:54 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] genirq/PM: Unexport {suspend,resume}_device_irqs()

On Fri, Jun 10, 2022 at 9:41 AM Lukas Wunner <lukas@...ner.de> wrote:
>
> Ever since {suspend,resume}_device_irqs() were introduced in 2009
> by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
> resuming device interrupts"), they've been exported even though there
> are no module users and never will be:  The functions are solely called
> by the PM core, which is always built-in.  Unexport them.
>
> Signed-off-by: Lukas Wunner <lukas@...ner.de>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

or I can take it if no one else does.

> ---
>  kernel/irq/pm.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index ca71123a6130..c556bc49d213 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -147,7 +147,6 @@ void suspend_device_irqs(void)
>                         synchronize_irq(irq);
>         }
>  }
> -EXPORT_SYMBOL_GPL(suspend_device_irqs);
>
>  static void resume_irq(struct irq_desc *desc)
>  {
> @@ -259,4 +258,3 @@ void resume_device_irqs(void)
>  {
>         resume_irqs(false);
>  }
> -EXPORT_SYMBOL_GPL(resume_device_irqs);
> --
> 2.35.2
>