linux-kernel - Re: [PATCH] module: Fix selfAssignment cppcheck warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqXEDCzsYvDKsgQa@localhost.localdomain>
Date:   Sun, 12 Jun 2022 13:46:36 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     christophe.leroy@...roup.eu
Cc:     linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org
Subject: Re: [PATCH] module: Fix selfAssignment cppcheck warning

> @@ -33,7 +33,8 @@
> #ifdef CONFIG_STRICT_MODULE_RWX
> # define strict_align(X) PAGE_ALIGN(X)
> #else
> -# define strict_align(X) (X)
> +/* OR with zero to avoid cppcheck selfAssignment warning */
> +# define strict_align(X) ((X) | 0)
>  #endif

Can these myopic tools be taught to see around and notice second
definition which does mutate variable so there is no self-assignment?