linux-kernel - Re: [PATCH v6 0/4] fat: add support for the renameat2 RENAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874k0qyx0z.fsf@mail.parknet.co.jp>
Date:   Sun, 12 Jun 2022 19:51:56 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org,
        Christian Kellner <ckellner@...hat.com>,
        Alberto Ruiz <aruiz@...hat.com>,
        Peter Jones <pjones@...hat.com>,
        Chung-Chiang Cheng <cccheng@...ology.com>,
        Carlos Maiolino <cmaiolin@...hat.com>,
        Lennart Poettering <lennart@...ttering.net>,
        Alexander Larsson <alexl@...hat.com>,
        Colin Walters <walters@...bum.org>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v6 0/4] fat: add support for the renameat2
 RENAME_EXCHANGE flag

Javier Martinez Canillas <javierm@...hat.com> writes:

> The series adds support for the renameat2 system call RENAME_EXCHANGE flag
> (which allows to atomically replace two paths) to the vfat filesystem code.
>
> There are many use cases for this, but we are particularly interested in
> making possible for vfat filesystems to be part of OSTree [0] deployments.
>
> Currently OSTree relies on symbolic links to make the deployment updates
> an atomic transactional operation. But RENAME_EXCHANGE could be used [1]
> to achieve a similar level of robustness when using a vfat filesystem.
>
> Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE
> support, patch #2 moves some code blocks in vfat_rename() to a set of
> helper functions, that can be reused by tvfat_rename_exchange() that's
> added by patch #3 and finally patch #4 adds some kselftests to test it.
>
> This is a v6 that addresses issues pointed out in v5:
>
> https://lkml.org/lkml/2022/6/9/361
>
> [0]: https://github.com/ostreedev/ostree
> [1]: https://github.com/ostreedev/ostree/issues/1649

Looks good this patchset.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>