linux-kernel - [PATCH] drm: fix device_node_continue.cocci warnings (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Jun 2022 13:02:31 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>
cc:     kbuild-all@...ts.01.org, lkp@...el.com,
        Linux Memory Management List <linux-mm@...ck.org>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH] drm: fix device_node_continue.cocci warnings (fwd)

The of_node_put does not seem to be needed.  Note that there is none at
the preceeding continues.

julia

---------- Forwarded message ----------
Date: Sat, 11 Jun 2022 06:02:45 +0800
From: kernel test robot <lkp@...el.com>
To: kbuild@...ts.01.org
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] drm: fix device_node_continue.cocci warnings

CC: kbuild-all@...ts.01.org
BCC: lkp@...el.com
CC: Linux Memory Management List <linux-mm@...ck.org>
TO: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
CC: Maxime Ripard <mripard@...nel.org>
CC: David Airlie <airlied@...ux.ie>
CC: Daniel Vetter <daniel@...ll.ch>
CC: dri-devel@...ts.freedesktop.org
CC: linux-kernel@...r.kernel.org

From: kernel test robot <lkp@...el.com>

drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   6d0c806803170f120f8cb97b321de7bd89d3a791
commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller
:::::: branch date: 17 hours ago
:::::: commit date: 31 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/gpu/drm/logicvc/logicvc_layer.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d
 		ret = logicvc_layer_init(logicvc, layer_node, index);
 		if (ret)
 			goto error;
-
-		of_node_put(layer_node);
 	}

 	of_node_put(layers_node);