linux-kernel - Re: [PATCH] drm: fix device_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Jun 2022 17:08:19 +0200
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     kbuild-all@...ts.01.org, lkp@...el.com,
        Linux Memory Management List <linux-mm@...ck.org>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: fix device_node_continue.cocci warnings (fwd)

Hi Julia,

On Sun 12 Jun 22, 13:02, Julia Lawall wrote:
> The of_node_put does not seem to be needed.  Note that there is none at
> the preceeding continues.

That looks like a correct fix, thanks!

Paul
 
> julia
> 
> ---------- Forwarded message ----------
> Date: Sat, 11 Jun 2022 06:02:45 +0800
> From: kernel test robot <lkp@...el.com>
> To: kbuild@...ts.01.org
> Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
> Subject: [PATCH] drm: fix device_node_continue.cocci warnings
> 
> CC: kbuild-all@...ts.01.org
> BCC: lkp@...el.com
> CC: Linux Memory Management List <linux-mm@...ck.org>
> TO: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> CC: Maxime Ripard <mripard@...nel.org>
> CC: David Airlie <airlied@...ux.ie>
> CC: Daniel Vetter <daniel@...ll.ch>
> CC: dri-devel@...ts.freedesktop.org
> CC: linux-kernel@...r.kernel.org
> 
> From: kernel test robot <lkp@...el.com>
> 
> drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.
> 
>  Device node iterators put the previous value of the index variable, so an
>  explicit put causes a double put.
> 
> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   6d0c806803170f120f8cb97b321de7bd89d3a791
> commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller
> :::::: branch date: 17 hours ago
> :::::: commit date: 31 hours ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  drivers/gpu/drm/logicvc/logicvc_layer.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d
>  		ret = logicvc_layer_init(logicvc, layer_node, index);
>  		if (ret)
>  			goto error;
> -
> -		of_node_put(layer_node);
>  	}
> 
>  	of_node_put(layers_node);

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)