[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YqZlyBH349VIdQDI@oden.dyn.berto.se>
Date: Mon, 13 Jun 2022 00:16:40 +0200
From: Niklas Söderlund
<niklas.soderlund@...natech.se>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: thermal: rcar-gen3-thermal: use
positive logic
Hi Wolfram,
Thanks for your patch.
On 2022-06-10 22:17:00 +0200, Wolfram Sang wrote:
> When handling the V3U/r8a779a0 exception, avoid using 'not:' because
> then its subschemas are far away in the 'else:' branch. Keep them
> together using positive logic.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> ---
>
> Changes since v2:
> * new patch
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 21 +++++++++----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 1368d90da0e8..72dc7eb27f8d 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -57,31 +57,30 @@ required:
> - "#thermal-sensor-cells"
>
> if:
> - not:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,r8a779a0-thermal
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779a0-thermal
> then:
> properties:
> reg:
> - minItems: 2
> items:
> + - description: TSC0 registers
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + - description: TSC4 registers
> else:
> properties:
> reg:
> + minItems: 2
> items:
> - - description: TSC0 registers
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - - description: TSC4 registers
> + required:
> + - interrupts
>
> additionalProperties: false
>
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
Powered by blists - more mailing lists