[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YqZmGQuEEks8Yl/N@oden.dyn.berto.se>
Date: Mon, 13 Jun 2022 00:18:01 +0200
From: Niklas Söderlund
<niklas.soderlund@...natech.se>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: thermal: rcar-gen3-thermal: Add
r8a779f0 support
Hi Wolfram,
Thanks for your work.
On 2022-06-10 22:17:01 +0200, Wolfram Sang wrote:
> Add support for R-Car S4. The S4 IP differs a bit from its siblings in
> such way that it has 3 out of 4 TSC nodes for Linux and the interrupts
> are not routed to the INTC-AP but to the ECM.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
> ---
>
> Change since V2:
> * make interrupts not required for this SoC
>
> Tested with:
> make dtbs_check DT_SCHEMA_FILES=thermal/rcar-gen3-thermal.yaml
>
> .../bindings/thermal/rcar-gen3-thermal.yaml | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> index 72dc7eb27f8d..0f05f5c886c5 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml
> @@ -8,9 +8,9 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Renesas R-Car Gen3 Thermal Sensor
>
> description:
> - On R-Car Gen3 SoCs, the thermal sensor controllers (TSC) control the thermal
> - sensors (THS) which are the analog circuits for measuring temperature (Tj)
> - inside the LSI.
> + On most R-Car Gen3 and later SoCs, the thermal sensor controllers (TSC)
> + control the thermal sensors (THS) which are the analog circuits for
> + measuring temperature (Tj) inside the LSI.
>
> maintainers:
> - Niklas Söderlund <niklas.soderlund@...natech.se>
> @@ -27,6 +27,7 @@ properties:
> - renesas,r8a77965-thermal # R-Car M3-N
> - renesas,r8a77980-thermal # R-Car V3H
> - renesas,r8a779a0-thermal # R-Car V3U
> + - renesas,r8a779f0-thermal # R-Car S4-8
>
> reg: true
>
> @@ -79,8 +80,16 @@ else:
> - description: TSC1 registers
> - description: TSC2 registers
> - description: TSC3 registers
> - required:
> - - interrupts
> + if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,r8a779f0-thermal
> + then:
> + required:
> + - interrupts
>
> additionalProperties: false
>
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
Powered by blists - more mailing lists