linux-kernel - Re: [PATCH] mm: check the function kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202206132134.VtqdhH9v-lkp@intel.com>
Date:   Mon, 13 Jun 2022 21:37:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ren Yu <renyu@...china.com>, cl@...ux.com
Cc:     kbuild-all@...ts.01.org, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz,
        roman.gushchin@...ux.dev, 42.hyeyoo@...il.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, liqiong@...china.com,
        qixu@...china.com, hukun@...china.com, yuzhe@...china.com,
        Ren Yu <renyu@...china.com>
Subject: Re: [PATCH] mm: check the function kmalloc_slab return value

Hi Ren,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Ren-Yu/mm-check-the-function-kmalloc_slab-return-value/20220613-182849
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220613/202206132134.VtqdhH9v-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/5ba2024be9e85177c986e9078e903798cac72f74
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ren-Yu/mm-check-the-function-kmalloc_slab-return-value/20220613-182849
        git checkout 5ba2024be9e85177c986e9078e903798cac72f74
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   mm/slab.c: In function '__kmem_cache_create':
>> mm/slab.c:2068:38: warning: returning 'struct kmem_cache *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
    2068 |                         return cachep->freelist_cache;
         |                                ~~~~~~^~~~~~~~~~~~~~~~


vim +2068 mm/slab.c

  2063	
  2064		if (OFF_SLAB(cachep)) {
  2065			cachep->freelist_cache =
  2066				kmalloc_slab(cachep->freelist_size, 0u);
  2067			if (unlikely(ZERO_OR_NULL_PTR(cachep->freelist_cache)))
> 2068				return cachep->freelist_cache;
  2069		}
  2070	
  2071		err = setup_cpu_cache(cachep, gfp);
  2072		if (err) {
  2073			__kmem_cache_release(cachep);
  2074			return err;
  2075		}
  2076	
  2077		return 0;
  2078	}
  2079	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp