linux-kernel - Re: [PATCH V2] selftests/vm: Add protection_keys tests to run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e7fca3a-096c-7d6c-e43b-9292995ab970@linuxfoundation.org>
Date:   Mon, 13 Jun 2022 15:44:45 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Kalpana Shetty <kalpana.shetty@....com>, akpm@...ux-foundation.org,
        shuah@...nel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests

On 6/10/22 3:07 AM, Kalpana Shetty wrote:
> Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests
> from a single shell script.
> 

Makes sense - can you explain why you can't just run
protection_keys_32 without checks? Why are you checking
for VADDR64? All of this information helps us review the
patch and give you feedback and suggest a different approach.

> Signed-off-by: Kalpana Shetty <kalpana.shetty@....com>
> ---
>   Changes in V2:
>    * Added patch description.
> 

thanks,
-- Shuah