linux-kernel - Re: [PATCH V2] selftests/vm: Add protection_keys tests to run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1703fcf-c5e2-70b1-cae2-30330108ad26@amd.com>
Date:   Tue, 14 Jun 2022 17:45:31 +0530
From:   "Shetty, Kalpana" <kalpana.shetty@....com>
To:     Shuah Khan <skhan@...uxfoundation.org>, akpm@...ux-foundation.org,
        shuah@...nel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests


On 6/14/2022 3:14 AM, Shuah Khan wrote:
> On 6/10/22 3:07 AM, Kalpana Shetty wrote:
>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to 
>> run all VM related tests
>> from a single shell script.
>>
>
> Makes sense - can you explain why you can't just run
> protection_keys_32 without checks? 

Yes; we can run protection_keys_32 without check.


> Why are you checking for VADDR64? 

The check is added to ensure if the system is in 64-bit mode before 
executing 64-bit binary.


> All of this information helps us review the
> patch and give you feedback and suggest a different approach.


Thanks,

Kalpana

>
>> Signed-off-by: Kalpana Shetty <kalpana.shetty@....com>
>> ---
>>   Changes in V2:
>>    * Added patch description.
>>
>
> thanks,
> -- Shuah