linux-kernel - Re: [PATCH 4/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 17:47:34 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     daniel watson <ozzloy@...llenge-bot.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: r8188eu: remove leading '_' on
 _rtw_IOL_append_WRF_cmd

On Mon, Jun 13, 2022 at 07:07:33PM -0700, daniel watson wrote:
> From: Daniel Watson <ozzloy@...llenge-bot.com>
> 
> name the function rtw_IOL_append_WRF_cmd and call it directly,
  ^^^^^^^^
Where is the first part of the sentence?

> instead of using wrapper macro
> 
> delete wrapper macro, which is not needed
> 
> NOTE: code compiles, not tested on hardware
> 
> Signed-off-by: Daniel Watson <ozzloy@...llenge-bot.com>
> 
> staging: r8188eu: remove leading '_' on  _rtw_IOL_append_WRF_cmd
> 
> call rtw_IOL_append_WRF_cmd directly instead of using wrapper macro

This is a better commit message but use a capital C "Call".

> delete wrapper macro, which is not needed
> 
> NOTE: code compiles, not tested on hardware
> 
> Signed-off-by: Daniel Watson <ozzloy@...llenge-bot.com>

You have the commit message twice.

regards,
dan carpenter