lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jun 2022 17:42:45 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: daniel watson <ozzloy@...llenge-bot.com> Cc: Larry Finger <Larry.Finger@...inger.net>, Phillip Potter <phil@...lpotter.co.uk>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] staging: r8188eu: remove leading '_' on _rtw_IOL_append_WB_cmd On Mon, Jun 13, 2022 at 07:07:30PM -0700, daniel watson wrote: > From: Daniel Watson <ozzloy@...llenge-bot.com> > > name the function rtw_IOL_append_WB_cmd and call it directly, > instead of using wrapper macro > > delete wrapper macro, which is not needed > > NOTE: code compiles, not tested on hardware Don't put this kind of comment in the commit message. Put it under the --- cut off line. > > Signed-off-by: Daniel Watson <ozzloy@...llenge-bot.com> > --- ^^^ Here. You don't even really need to tell us that you compiled the code, because we take that as a given. regards, dan carpenter
Powered by blists - more mailing lists