[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220614152503.1410755-1-robh@kernel.org>
Date: Tue, 14 Jun 2022 09:25:03 -0600
From: Rob Herring <robh@...nel.org>
To: Martin PoviĊĦer <povik+lin@...ebit.org>,
Vinod Koul <vkoul@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] dt-bindings: dma: apple,admac: Fix example interrupt parsing
Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning
in its example:
Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@...200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml
The problem is the number of interrupt cells can't be guessed when
there are empty '0' entries. So the example must have a valid interrupt
controller defining the number of interrupt cells.
Fixes: 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC")
Signed-off-by: Rob Herring <robh@...nel.org>
---
Documentation/devicetree/bindings/dma/apple,admac.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml
index ab8a4ec7779f..bdc8c129c4f5 100644
--- a/Documentation/devicetree/bindings/dma/apple,admac.yaml
+++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml
@@ -63,6 +63,11 @@ examples:
#include <dt-bindings/interrupt-controller/apple-aic.h>
#include <dt-bindings/interrupt-controller/irq.h>
+ aic: interrupt-controller {
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ };
+
admac: dma-controller@...200000 {
compatible = "apple,t8103-admac", "apple,admac";
reg = <0x38200000 0x34000>;
--
2.34.1
Powered by blists - more mailing lists