linux-kernel - Re: [PATCH] dt-bindings: dma: apple,admac: Fix example interrupt parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6F273631-05A0-4766-BB5D-BD056D1BFEDB@cutebit.org>
Date:   Tue, 14 Jun 2022 17:38:15 +0200
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: apple,admac: Fix example interrupt
 parsing


> On 14. 6. 2022, at 17:25, Rob Herring <robh@...nel.org> wrote:
> 
> Commit 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC") has a warning
> in its example:
> 
> Documentation/devicetree/bindings/dma/apple,admac.example.dtb: dma-controller@...200000: interrupts-extended: [[0], [4294967295, 0, 626, 4, 0, 0]] is too short
> 	From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/dma/apple,admac.yaml
> 
> The problem is the number of interrupt cells can't be guessed when
> there are empty '0' entries. So the example must have a valid interrupt
> controller defining the number of interrupt cells.
> 
> Fixes: 873971f8fb08 ("dt-bindings: dma: Add Apple ADMAC")
> Signed-off-by: Rob Herring <robh@...nel.org>

Thanks,

Acked-by: Martin Povišer <povik+lin@...ebit.org>