linux-kernel - Re: [PATCH] KVM: x86/mmu: Remove unused "type" of split_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJncD7Tn4i59SR=Ee-dEXkXq74g8LEzRQ7X=fE92kM26BFocig@mail.gmail.com>
Date:   Tue, 14 Jun 2022 08:52:34 +0800
From:   sunliming <kelulanainsley@...il.com>
To:     Xiaoyao Li <xiaoyao.li@...el.com>
Cc:     isaku.yamahata@...el.com, pbonzini@...hat.com, seanjc@...gle.com,
        mingo@...nel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] KVM: x86/mmu: Remove unused "type" of split_page_type()

I got it, I am sorry aboot it , thanks.

Xiaoyao Li <xiaoyao.li@...el.com> 于2022年6月13日周一 10:48写道：

>
> On 6/12/2022 11:56 AM, sunliming wrote:
> > The variable 'type' in split_page_type() is set but not used, so remove
> > it.
> >
> > Fixes the following w1 warning:
> >
> > arch/x86/kvm/mmu/mmu.c:982:28: warning: variable 'type' set but not used [-Wunused-but-set-variable]
>
> Please note, the code doesn't get into upstream yet.
>
> The fix shouldn't be sent to upstream maillist.
>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: sunliming <sunliming@...inos.cn>
> > ---
> >   arch/x86/kvm/mmu/mmu.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> > index 7b3df91a93cf..f4d577335f94 100644
> > --- a/arch/x86/kvm/mmu/mmu.c
> > +++ b/arch/x86/kvm/mmu/mmu.c
> > @@ -979,14 +979,12 @@ static void split_page_type(gfn_t gfn, struct kvm_memory_slot *slot,
> >                           enum pg_level level)
> >   {
> >       struct kvm_page_attr *page_attr = page_attr_slot(gfn, slot, level);
> > -     enum kvm_page_type type;
> >       gfn_t base_gfn;
> >
> >       if (WARN_ON_ONCE(!kvm_page_type_valid(page_attr) || level <= PG_LEVEL_4K))
> >               return;
> >
> >       base_gfn = gfn & ~(KVM_PAGES_PER_HPAGE(level) - 1);
> > -     type = page_attr->type;
> >
> >       /*
> >        * Set the type to KVM_PAGE_TYPE_MIXED in advance since when a large
>