linux-kernel - Re: [PATCH RESEND] of: Add missing function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 08:52:59 +0800
From:   sunliming <kelulanainsley@...il.com>
To:     Jonathan McDowell <noodles@...com>
Cc:     "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "bhe@...hat.com" <bhe@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH RESEND] of: Add missing function declarations

OK，thanks

Jonathan McDowell <noodles@...com> 于2022年6月13日周一 17:03写道：
>
> NAK. This is for a patch of mine that I don't believe has hit mainline
> yet - I've only seen it in daveh's test tree. The prototypes for these
> functions are now guarded by CONFIG_HAVE_IMA_KEXEC but all OF platforms
> build them even when the platform doesn't actually support IMA over
> kexec. I'll update my patch to avoid that.
>
> On Sun, Jun 12, 2022 at 03:15:35PM +0800, sunliming wrote:
> > Fixes the following w1 warning:
> >
> > drivers/of/kexec.c:126:5: warning: no previous prototype for 'ima_get_kexec_buffer' [-Wmissing-prototypes]
> > drivers/of/kexec.c:153:5: warning: no previous prototype for 'ima_free_kexec_buffer' [-Wmissing-prototypes
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: sunliming <sunliming@...inos.cn>
> > ---
> >  include/linux/of.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index f0a5d6b10c5a..3a166a1c4ef6 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -844,6 +844,16 @@ static inline phys_addr_t of_dma_get_max_cpu_address(struct device_node *np)
> >       return PHYS_ADDR_MAX;
> >  }
> >
> > +static inline int ima_get_kexec_buffer(void **addr, size_t *size)
> > +{
> > +        return -ENOSYS;
> > +}
> > +
> > +static inline int ima_free_kexec_buffer(void **addr, size_t *size)
> > +{
> > +        return -ENOSYS;
> > +}
> > +
> >  #define of_match_ptr(_ptr)   NULL
> >  #define of_match_node(_matches, _node)       NULL
> >  #endif /* CONFIG_OF */
> > --
> > 2.25.1
> >