[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220614021009.696-1-liew.s.piaw@gmail.com>
Date: Tue, 14 Jun 2022 10:10:09 +0800
From: Sieng Piaw Liew <liew.s.piaw@...il.com>
To: davem@...emloft.com, edumazet@...gle.com, kuba@...nel.org,
f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Sieng Piaw Liew <liew.s.piaw@...il.com>
Subject: [PATCH] bcm63xx_enet: reuse skbuff_head
napi_build_skb() reuses NAPI skbuff_head cache in order to save some
cycles on freeing/allocating skbuff_heads on every new Rx or completed
Tx.
Use napi_consume_skb() to feed the cache with skbuff_heads of completed
Tx so it's never empty.
Signed-off-by: Sieng Piaw Liew <liew.s.piaw@...il.com>
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
index 698438a2ee0f..514d61dd91c7 100644
--- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
@@ -388,7 +388,7 @@ static int bcm_enet_receive_queue(struct net_device *dev, int budget)
priv->rx_buf_size, DMA_FROM_DEVICE);
priv->rx_buf[desc_idx] = NULL;
- skb = build_skb(buf, priv->rx_frag_size);
+ skb = napi_build_skb(buf, priv->rx_frag_size);
if (unlikely(!skb)) {
skb_free_frag(buf);
dev->stats.rx_dropped++;
@@ -468,7 +468,7 @@ static int bcm_enet_tx_reclaim(struct net_device *dev, int force)
dev->stats.tx_errors++;
bytes += skb->len;
- dev_kfree_skb(skb);
+ napi_consume_skb(skb, !force);
released++;
}
--
2.17.1
Powered by blists - more mailing lists