linux-kernel - Re: [PATCH] bcm63xx_enet: reuse skbuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd6fa416-ba17-e0fe-c89c-0abcc6c3fd44@gmail.com>
Date:   Tue, 14 Jun 2022 09:12:14 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Sieng Piaw Liew <liew.s.piaw@...il.com>, davem@...emloft.com,
        edumazet@...gle.com, kuba@...nel.org, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: reuse skbuff_head

On 6/13/22 19:10, Sieng Piaw Liew wrote:
> napi_build_skb() reuses NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed
> Tx.
> Use napi_consume_skb() to feed the cache with skbuff_heads of completed
> Tx so it's never empty.
> 
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian