[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220614215006.67893ec1@kernel.org>
Date: Tue, 14 Jun 2022 21:50:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sieng Piaw Liew <liew.s.piaw@...il.com>
Cc: davem@...emloft.com, edumazet@...gle.com, f.fainelli@...il.com,
bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: reuse skbuff_head
On Tue, 14 Jun 2022 10:10:09 +0800 Sieng Piaw Liew wrote:
> Subject: [PATCH] bcm63xx_enet: reuse skbuff_head
Please improve the subject. One verb and one vaguely correct noun
is not good enough.
> napi_build_skb() reuses NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed
> Tx.
> Use napi_consume_skb() to feed the cache with skbuff_heads of completed
> Tx so it's never empty.
>
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@...il.com>
Please keep Florian's Ack when posting v2.
Powered by blists - more mailing lists