linux-kernel - Re: [PATCH] Fix the following checkpatch error:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jun 2022 12:55:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     jingyuwang <jingyuwang_vip@....com>, akpm@...ux-foundation.org,
        rostedt@...dmis.org, mhiramat@...nel.org, vbabka@...e.cz,
        ahalaney@...hat.com, Jason@...c4.com, mark-pk.tsai@...iatek.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, jingyuwang <jingyuwang_vip@....com>
Subject: Re: [PATCH] Fix the following checkpatch error:

Hi jingyuwang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v5.19-rc2 next-20220610]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/jingyuwang/Fix-the-following-checkpatch-error/20220614-050258
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: hexagon-randconfig-r041-20220613 (https://download.01.org/0day-ci/archive/20220614/202206141212.iXl6qYYx-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c97436f8b6e2718286e8496faf53a2c800e281cf)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/35742a839670fa8937c7040160e16b7009b2a9ae
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review jingyuwang/Fix-the-following-checkpatch-error/20220614-050258
        git checkout 35742a839670fa8937c7040160e16b7009b2a9ae
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   init/main.c:773:20: warning: no previous prototype for function 'arch_post_acpi_subsys_init' [-Wmissing-prototypes]
   void __init __weak arch_post_acpi_subsys_init(void) { }
                      ^
   init/main.c:773:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __init __weak arch_post_acpi_subsys_init(void) { }
   ^
   static 
   init/main.c:785:20: warning: no previous prototype for function 'mem_encrypt_init' [-Wmissing-prototypes]
   void __init __weak mem_encrypt_init(void) { }
                      ^
   init/main.c:785:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __init __weak mem_encrypt_init(void) { }
   ^
   static 
   init/main.c:787:20: warning: no previous prototype for function 'poking_init' [-Wmissing-prototypes]
   void __init __weak poking_init(void) { }
                      ^
   init/main.c:787:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __init __weak poking_init(void) { }
   ^
   static 
>> init/main.c:1344:20: error: 'initcall_level_names' causes a section type conflict with '__setup_str_set_reset_devices'
   static const char *initcall_level_names[] __initconst = {
                      ^
   init/main.c:191:1: note: declared here
   __setup("reset_devices", set_reset_devices);
   ^
   include/linux/init.h:329:2: note: expanded from macro '__setup'
           __setup_param(str, fn, fn, 0)
           ^
   include/linux/init.h:316:20: note: expanded from macro '__setup_param'
           static const char __setup_str_##unique_id[] __initconst         \
                             ^
   <scratch space>:58:1: note: expanded from here
   __setup_str_set_reset_devices
   ^
   3 warnings and 1 error generated.


vim +1344 init/main.c

  1342	
  1343	/* Keep these in sync with initcalls in include/linux/init.h */
> 1344	static const char *initcall_level_names[] __initconst = {
  1345		"pure",
  1346		"core",
  1347		"postcore",
  1348		"arch",
  1349		"subsys",
  1350		"fs",
  1351		"device",
  1352		"late",
  1353	};
  1354	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp