linux-kernel - Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdFPUHTeDBY5ukFgVqJJn7BbTHxrxKUGOLB6P1UX-utAg@mail.gmail.com>
Date:   Wed, 15 Jun 2022 13:24:06 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     stefan.seyfried@...glemail.com
Cc:     Kenneth Chan <kenneth.t.chan@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stefan Seyfried <seife+kernel@...systems.com>
Subject: Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys

On Wed, Jun 15, 2022 at 1:21 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Sun, Jun 12, 2022 at 3:54 PM <stefan.seyfried@...glemail.com> wrote:

> We usually add module options in very bad cases where it's very useful
> for debugging or when some devices require the opposite settings while
> can't be distinguished automatically. Here I do not see either of such
> cases. Hence, I would prefer to see a DMI based quirk as it's done a
> lot in the PDx86 drivers. Can you do that?

Looking into the code of the culprit patch, have you tried to add a
debug pr_info() and see what value is in the result? Perhaps you may
just sort out by correcting that.

-- 
With Best Regards,
Andy Shevchenko