linux-kernel - Re: [PATCH -next] dmaengine: apple-admac: Fix build on 32-bit/non-LPAE platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4D5BB835-5DF0-4BBB-B073-A77F1A96EA19@cutebit.org>
Date:   Wed, 15 Jun 2022 14:07:12 +0200
From:   Martin Povišer <povik+lin@...ebit.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Vinod Koul <vkoul@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] dmaengine: apple-admac: Fix build on
 32-bit/non-LPAE platforms


> On 14. 6. 2022, at 9:49, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> 
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
> 
>    drivers/dma/apple-admac.c: In function ‘admac_cyclic_write_one_desc’:
>    drivers/dma/apple-admac.c:213:22: error: right shift count >= width of type [-Werror=shift-count-overflow]
>      213 |  writel_relaxed(addr >> 32,       ad->base + REG_DESC_WRITE(channo));
>          |                      ^~
> 
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain the
> address parts.
> 
> Reported-by: noreply@...erman.id.au
> Fixes: b127315d9a78c011 ("dmaengine: apple-admac: Add Apple ADMAC driver")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks! (TIL about the lower/upper_32_bits helpers)

Acked-by: Martin Povišer <povik+lin@...ebit.org>