linux-kernel - Re: [PATCH v2] spi: microchip-core: fix passing zero to PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165537976740.874420.15190272235131912340.b4-ty@kernel.org>
Date:   Thu, 16 Jun 2022 12:42:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     conor.dooley@...rochip.com
Cc:     linux-riscv@...ts.infradead.org, linux-spi@...r.kernel.org,
        dan.carpenter@...cle.com, daire.mcnamara@...rochip.com,
        lewis.hanly@...rochip.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi: microchip-core: fix passing zero to PTR_ERR warning

On Wed, 15 Jun 2022 15:20:29 +0100, Conor Dooley wrote:
> It is possible that the error case for devm_clk_get() returns NULL,
> in which case zero will be passed to PTR_ERR() as shown by the Smatch
> static checker warning:
> drivers/spi/spi-microchip-core.c:557 mchp_corespi_probe()
> warn: passing zero to 'PTR_ERR'
> 
> Remove the NULL check and carry on with a dummy clock in case of an
> error. To avoid a potential div zero, abort calculating clkgen if
> clk_get_rate(spi->clk) is zero.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: microchip-core: fix passing zero to PTR_ERR warning
      commit: 2081ad1467469b649fc9f9226b235977a7bf9402

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark