linux-kernel - Re: [PATCH] mm: hugetlb: rework hugetlb cmdline parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yqwxlo7HYFv4jHco@FVFYT0MHHV2J.usts.net>
Date:   Fri, 17 Jun 2022 15:47:34 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     "mike.kravetz@...cle.com" <mike.kravetz@...cle.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: hugetlb: rework hugetlb cmdline parsing

On Thu, Jun 16, 2022 at 08:00:58AM +0000, Christophe Leroy wrote:
> 
> 
> Le 16/06/2022 à 09:18, Muchun Song a écrit :
> > I often get lost in the logic interleaved between numerous global
> > variables for parsing cmdline.  It is not easy to be maintained.
> > This patch aims to rework cmdline parsing to simlify the code and
> > make the code more readable.
> 
> This patch is quite big.
> 
> Can you explain in the commit description in more details what are the 
> changes performed by this patch ?
> 
> Otherwise I have absolutely no idea of what to review or what to test.
>

Sorry for the confusing, I'll rework the commit message in v2.

Thanks.