[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220617122505.4048126-1-windhl@126.com>
Date: Fri, 17 Jun 2022 20:25:05 +0800
From: Liang He <windhl@....com>
To: john@...ozen.org, tsbogend@...ha.franken.de,
xkernel.wang@...mail.com
Cc: windhl@....com, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl
In ltq_soc_init(), of_find_compatible_node() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.
Signed-off-by: Liang He <windhl@....com>
---
arch/mips/lantiq/xway/sysctrl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
index 084f6caba5f2..d444a1b98a72 100644
--- a/arch/mips/lantiq/xway/sysctrl.c
+++ b/arch/mips/lantiq/xway/sysctrl.c
@@ -441,6 +441,10 @@ void __init ltq_soc_init(void)
of_address_to_resource(np_ebu, 0, &res_ebu))
panic("Failed to get core resources");
+ of_node_put(np_pmu);
+ of_node_put(np_cgu);
+ of_node_put(np_ebu);
+
if (!request_mem_region(res_pmu.start, resource_size(&res_pmu),
res_pmu.name) ||
!request_mem_region(res_cgu.start, resource_size(&res_cgu),
--
2.25.1
Powered by blists - more mailing lists