linux-kernel - Re: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220621151548.GE12206@alpha.franken.de>
Date:   Tue, 21 Jun 2022 17:15:48 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Liang He <windhl@....com>
Cc:     john@...ozen.org, xkernel.wang@...mail.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: lantiq: xway: Fix refcount leak bug in sysctrl

On Fri, Jun 17, 2022 at 08:25:05PM +0800, Liang He wrote:
> In ltq_soc_init(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.
> 
> Signed-off-by: Liang He <windhl@....com>
> ---
>  arch/mips/lantiq/xway/sysctrl.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
> index 084f6caba5f2..d444a1b98a72 100644
> --- a/arch/mips/lantiq/xway/sysctrl.c
> +++ b/arch/mips/lantiq/xway/sysctrl.c
> @@ -441,6 +441,10 @@ void __init ltq_soc_init(void)
>  			of_address_to_resource(np_ebu, 0, &res_ebu))
>  		panic("Failed to get core resources");
>  
> +	of_node_put(np_pmu);
> +	of_node_put(np_cgu);
> +	of_node_put(np_ebu);
> +
>  	if (!request_mem_region(res_pmu.start, resource_size(&res_pmu),
>  				res_pmu.name) ||
>  		!request_mem_region(res_cgu.start, resource_size(&res_cgu),
> -- 
> 2.25.1

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]