linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tu8j2x9u.wl-maz@kernel.org>
Date:   Fri, 17 Jun 2022 15:13:33 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Matt Ranostay <mranostay@...com>
Cc:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Robin Murphy <robin.murphy@....com>, Nishanth Menon <nm@...com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region

On Fri, 17 Jun 2022 15:02:07 +0100,
Matt Ranostay <mranostay@...com> wrote:
> 
> GICD region was overlapping with GICR causing the latter to not map
> successfully, and in turn the gic-v3 driver would fail to initialize.
> 
> This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")
> replaced of_iomap() calls with of_io_request_and_map() that internally
> called request_mem_region().

Please correctly wrap long lines in the commit message.

> 
> Respective console output before this patchset:
> 
> [    0.000000] GICv3: /bus@...000/interrupt-controller@...0000: couldn't map region 0
> 
> Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources")

No, that's the wrong target for this. Your patch fixes the *original*
submission of the DT, and this should carry a:

Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")

Please also consider adding a

Cc: stable@...r.kernel.org

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.