linux-kernel - Re: [PATCH] MAINTAINERS: Fix parsing usbhid from scripts/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c56ffea031f0b0d05fd856e10a2c1f6f72291e0.camel@perches.com>
Date:   Thu, 16 Jun 2022 19:37:25 -0700
From:   Joe Perches <joe@...ches.com>
To:     Mario Limonciello <mario.limonciello@....com>,
        benjamin.tissoires@...hat.com, jikos@...nel.org,
        open list <linux-kernel@...r.kernel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] MAINTAINERS: Fix parsing usbhid from
 scripts/get_maintainer.pl

On Thu, 2022-06-16 at 13:33 -0500, Mario Limonciello wrote:
> Recently trying to send a patch, I found that `./scripts/get_maintainer.pl`
> didn't want to parse the usbhid section because of too long of a line
> leading to a missing parenthesis.  To fix this, change () to [] so it can
> parse even the long line.

It'd almost certainly better to change get_maintainer as there are many
possible entries like this.

Perhaps:
---
 scripts/get_maintainer.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index ab123b498fd9b..2a8ee64cd7208 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1256,6 +1256,9 @@ sub get_subsystem_name {
 	$subsystem = substr($subsystem, 0, $output_section_maxlen - 3);
 	$subsystem =~ s/\s*$//;
 	$subsystem = $subsystem . "...";
+	my $openparens  = () = $subsystem =~ /\(/g;
+	my $closeparens = () = $subsystem =~ /\)/g;
+	$subsystem .= ')' x ($openparens - $closeparens) if ($openparens > $closeparens);
     }
     return $subsystem;
 }