linux-kernel - Re: [PATCH] MAINTAINERS: Fix parsing usbhid from scripts/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0b7573a146da0aee33b3b21c66805bedad598f3.camel@perches.com>
Date:   Thu, 16 Jun 2022 19:40:34 -0700
From:   Joe Perches <joe@...ches.com>
To:     Mario Limonciello <mario.limonciello@....com>,
        benjamin.tissoires@...hat.com, jikos@...nel.org,
        open list <linux-kernel@...r.kernel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] MAINTAINERS: Fix parsing usbhid from
 scripts/get_maintainer.pl

On Thu, 2022-06-16 at 13:33 -0500, Mario Limonciello wrote:
> Recently trying to send a patch, I found that `./scripts/get_maintainer.pl`
> didn't want to parse the usbhid section because of too long of a line
> leading to a missing parenthesis.  To fix this, change () to [] so it can
> parse even the long line.
[]
> (to-cmd) Adding to: linux-usb@...r.kernel.org (open list:USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REM...) from: 'scripts/get_maintainer.pl'
> (to-cmd) Adding to: linux-input@...r.kernel.org (open list:HID CORE LAYER) from: 'scripts/get_maintainer.pl'
> (to-cmd) Adding to: linux-kernel@...r.kernel.org (open list) from: 'scripts/get_maintainer.pl'
> Unmatched () '(open list:USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REM...)' '' at /usr/lib/git-core/git-send-email line 546.
> error: unable to extract a valid address from: linux-usb@...r.kernel.org (open list:USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REM...)

And it wasn't get_maintainer, it was git send-email that found that
the specific get_maintainer output was not a 'valid' email address
with a balanced parenthesis comment.

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -20537,7 +20537,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
>  F:	drivers/usb/gadget/
>  F:	include/linux/usb/gadget*
>  
> -USB HID/HIDBP DRIVERS (USB KEYBOARDS, MICE, REMOTE CONTROLS, ...)
> +USB HID/HIDBP DRIVERS [USB KEYBOARDS, MICE, REMOTE CONTROLS, ...]
>  M:	Jiri Kosina <jikos@...nel.org>
>  M:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
>  L:	linux-usb@...r.kernel.org