linux-kernel - Re: [PATCH] ext4: change variable "count" to signed integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jun 2022 12:33:01 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Theodore Ts'o <tytso@....edu>
Cc:     adilger.kernel@...ger.ca,
        Ding Xiang <dingxiang@...s.chinamobile.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Subject: Re: [PATCH] ext4: change variable "count" to signed integer

On Fri, Jun 17, 2022 at 10:59:01PM -0400, Theodore Ts'o wrote:
> On Mon, 30 May 2022 18:00:47 +0800, Ding Xiang wrote:
> > Since dx_make_map() may return -EFSCORRUPTED now,
> > so change "count" to signed integer.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/1] ext4: change variable "count" to signed integer
>       commit: fefb759df063599ad483422eb07ef8e14c612cc2
> 

There was some kind of process error here...

1) That commit somehow never made it to linux-next.

2) No Fixes tag.  Presumably Greg searches for Fixes tags before he back
ports patches.  The original commit 46c116b920eb ("ext4: verify dir
block before splitting it") has been back ported to stable already.

3) I don't know why I didn't send a patch for this bug.  I looked at it
on May 23 but never sent a patch.  Sorry?

4) There are a dozen other static checkers which are supposed to have
warned about this.  I search lore.kernel.org for 46c116b920eb
and 46c116b920ebec58031f0a78c5ea9599b0d2a371 but I couldn't find any
static checker warnings.

regards,
dan carpenter