linux-kernel - Re: [PATCH] ext4: change variable "count" to signed integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yq5QCJI7qC80AtxL@mit.edu>
Date:   Sat, 18 Jun 2022 18:22:00 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     adilger.kernel@...ger.ca,
        Ding Xiang <dingxiang@...s.chinamobile.com>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Subject: Re: [PATCH] ext4: change variable "count" to signed integer

On Sat, Jun 18, 2022 at 12:33:01PM +0300, Dan Carpenter wrote:
> On Fri, Jun 17, 2022 at 10:59:01PM -0400, Theodore Ts'o wrote:
> > On Mon, 30 May 2022 18:00:47 +0800, Ding Xiang wrote:
> > > Since dx_make_map() may return -EFSCORRUPTED now,
> > > so change "count" to signed integer.
> > > 
> > > 
> > 
> > Applied, thanks!
> > 
> > [1/1] ext4: change variable "count" to signed integer
> >       commit: fefb759df063599ad483422eb07ef8e14c612cc2
> > 
> 
> There was some kind of process error here...
> 
> 1) That commit somehow never made it to linux-next.

That's I only pushed it out Friday night (US/Eastern), and Stephen
Rothwell creates new linux-next release based on snapshots taken
Monday through Friday in the Morning (AU/Canberra time).

Things have been crazy busy, so a last set of ext4 backports only
happened Friday starting around 10pm localtime.  (Yes, I have no
life.)

> 2) No Fixes tag.  Presumably Greg searches for Fixes tags before he back
> ports patches.  The original commit 46c116b920eb ("ext4: verify dir
> block before splitting it") has been back ported to stable already.

I did add a Fixes tag in what is in the ext4 tree.  I don't always
mention when I've rewritten since that requries manual editing of the
"b4 ty" generated acknowledgement.

In the ideal world when I rewrite the one-line snapshot, at the *very*
least it should show up in the Applied/thanks.  Maybe something like
this:

[1/1] ext4: change variable "count" to signed integer
      commit: fefb759df063599ad483422eb07ef8e14c612cc2
      rewritten summary: ext4: make variable "count" signed

... and if the commit description is rewritten, maybe the "b4 ty"
e-mail should mention it.  (Very often I end up rewriting commit
descriptions, especially when the original poster's first language is
not English.)

For the record, this is what is in the ext4 tree that I plan to push
to Linus is:

commit fefb759df063599ad483422eb07ef8e14c612cc2
Author: Ding Xiang <dingxiang@...s.chinamobile.com>
Date:   Mon May 30 18:00:47 2022 +0800

    ext4: make variable "count" signed

    Since dx_make_map() may return -EFSCORRUPTED now, so change "count" to
    be a signed integer so we can correct check for an error code returned
    by dx_make_map().

    Fixes: 46c116b920eb ("ext4: verify dir block before splitting it")
    Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>
    Link: https://lore.kernel.org/r/20220530100047.537598-1-dingxiang@cmss.chinamobile.com
    Signed-off-by: Theodore Ts'o <tytso@....edu>

Cheers,

					- Ted